-
Notifications
You must be signed in to change notification settings - Fork 53
MLE-24531 Added echo of Docker image #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds logging statements to improve visibility during the Docker container startup process in the Jenkins pipeline. The changes add echo statements to display which Docker image is being used and indicate when the system is waiting for MarkLogic to be ready.
- Added echo statement to display the MarkLogic Docker image being used
- Added informational message about the 60-second wait period for MarkLogic startup
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Jenkinsfile
Outdated
| docker-compose down -v || true | ||
| sudo /usr/local/sbin/mladmin cleandata | ||
| cd node-client-api | ||
| echo "Running docker compose with MarkLogic image: ''' + markLogicDockerImage + '''" |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String concatenation syntax is incorrect. The triple quotes should be double quotes for proper Groovy string interpolation: echo \"Running docker compose with MarkLogic image: ${markLogicDockerImage}\"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot, this is your code you generated for me in VS Code!
bca4ae0 to
721116a
Compare
|
Please ignore the first jenkins run since it had permission issues on the machine. The second run looks good. |
No description provided.