Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 9, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 9, 2025 19:45
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Copyright Validation Results
Total: 1 | Passed: 0 | Failed: 0 | Skipped: 1 | at: 2025-10-09 19:48:16 UTC | commit: 721116a

⏭️ Skipped (Excluded) Files

  • Jenkinsfile

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds logging statements to improve visibility during the Docker container startup process in the Jenkins pipeline. The changes add echo statements to display which Docker image is being used and indicate when the system is waiting for MarkLogic to be ready.

  • Added echo statement to display the MarkLogic Docker image being used
  • Added informational message about the 60-second wait period for MarkLogic startup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Jenkinsfile Outdated
docker-compose down -v || true
sudo /usr/local/sbin/mladmin cleandata
cd node-client-api
echo "Running docker compose with MarkLogic image: ''' + markLogicDockerImage + '''"
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String concatenation syntax is incorrect. The triple quotes should be double quotes for proper Groovy string interpolation: echo \"Running docker compose with MarkLogic image: ${markLogicDockerImage}\"

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot, this is your code you generated for me in VS Code!

@rjrudin rjrudin force-pushed the feature/echo-image branch from bca4ae0 to 721116a Compare October 9, 2025 19:47
@anu3990
Copy link
Contributor

anu3990 commented Oct 9, 2025

Please ignore the first jenkins run since it had permission issues on the machine. The second run looks good.

@rjrudin rjrudin merged commit 730ff79 into develop Oct 10, 2025
2 of 3 checks passed
@rjrudin rjrudin deleted the feature/echo-image branch October 10, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants